Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: combine multiple trace tests into single file #175

Merged
merged 12 commits into from
Nov 11, 2022
Merged

refactor: combine multiple trace tests into single file #175

merged 12 commits into from
Nov 11, 2022

Conversation

hvanz
Copy link
Member

@hvanz hvanz commented Oct 28, 2022 •
edited
Loading

Closes #168

  • test trace on a directory will create a single pytest file with test cases for all traces, instead of one file per trace.
  • Refactor test trace and test model, as there was a lot of duplicate code.

@hvanz hvanz self-assigned this Oct 28, 2022
@hvanz hvanz added the enhancement New feature or request label Oct 28, 2022
@hvanz hvanz marked this pull request as ready for review October 28, 2022 09:16
rnbguy
rnbguy requested changes Nov 2, 2022
View reviewed changes
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I added some suggestions.

I noticed, this is only for test trace. test model still generates multiple test files. Do you think it would make sense to include that in this PR as well?

atomkraft/utils/filesystem.py Outdated Show resolved Hide resolved
atomkraft/utils/helpers.py Outdated Show resolved Hide resolved
atomkraft/utils/helpers.py Show resolved Hide resolved
atomkraft/test/model.py Outdated Show resolved Hide resolved
@rnbguy rnbguy changed the title Combine multiple trace tests into single file refactor: combine multiple trace tests into single file Nov 9, 2022
@rnbguy rnbguy force-pushed the hernan/test-trace-dir branch 2 times, most recently from ea8ffca to fe81343 Compare November 9, 2022 19:55
@hvanz
Copy link
Member Author

hvanz commented Nov 11, 2022

I noticed, this is only for test trace. test model still generates multiple test files. Do you think it would make sense to include that in this PR as well?

@rnbguy I included this change you suggested in this PR, together with a refactoring of all the testing functionality in a single Test class

rnbguy
rnbguy approved these changes Nov 11, 2022
View reviewed changes
Copy link
Member

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! Thanks for this PR.

@rnbguy rnbguy merged commit 6d692c6 into dev Nov 11, 2022
@rnbguy rnbguy deleted the hernan/test-trace-dir branch November 11, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnbguy rnbguy rnbguy approved these changes

@ivan-gavran ivan-gavran Awaiting requested review from ivan-gavran

Assignees

@hvanz hvanz

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Combine multiple trace tests into single file
2 participants
@hvanz @rnbguy